New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix when requiring a component in relation graph ql #5519
Fix when requiring a component in relation graph ql #5519
Conversation
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
…ationGraphQl Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
Codecov Report
@@ Coverage Diff @@
## master #5519 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 700 700
Lines 10330 10330
Branches 1687 1687
=======================================
Hits 1809 1809
Misses 7089 7089
Partials 1432 1432
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if the test pass :) Just one change to be done
@@ -52,11 +52,7 @@ const Wrapper = styled.tr` | |||
} | |||
} | |||
&.relation-row { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just undo the changes to this file as you did make any changes to it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #4556
Description of what you did: