Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when requiring a component in relation graph ql #5519

Merged

Conversation

petersg83
Copy link
Contributor

Fix #4556

Description of what you did:

  • populate with components even if populate option is already existing
  • add some tests

Pierre Noël added 2 commits March 16, 2020 15:43
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
…ationGraphQl

Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #5519 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5519   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10330    10330           
  Branches     1687     1687           
=======================================
  Hits         1809     1809           
  Misses       7089     7089           
  Partials     1432     1432           
Flag Coverage Δ
#front 12.88% <ø> (ø)
#unit 37.30% <ø> (ø)
Impacted Files Coverage Δ
...pe-builder/admin/src/components/ListRow/Wrapper.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbb395...c3f011d. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if the test pass :) Just one change to be done

@@ -52,11 +52,7 @@ const Wrapper = styled.tr`
}
}
&.relation-row {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just undo the changes to this file as you did make any changes to it :)

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package issue: bug Issue reporting a bug labels Mar 17, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 17, 2020
@alexandrebodin alexandrebodin merged commit ac1898e into master Mar 17, 2020
@alexandrebodin alexandrebodin deleted the fix/#4556/nullWhenRequiringAComponentInRelationGraphQl branch March 17, 2020 08:42
@alexandrebodin alexandrebodin changed the title Fix/#4556/null when requiring a component in relation graph ql Fix when requiring a component in relation graph ql Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying a relationships group fields returns null in GraphQL
2 participants