Fix context issue in custom GraphQL query and mutation

[iicdii]

Description of what you did:

Fix #5531 issue. Make policiesMiddleware works in custom resolvers too.

[alexandrebodin]

@iicdii Hi, Can you please fix the DCO check.

[alexandrebodin]

LGTM, Thanks !

Test breaking

[alexandrebodin]

@iicdii The tests are breaking with your changes.

[iicdii]

@alexandrebodin I'll check the code.

[codecov]

Codecov Report

Merging #5532 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
- Coverage   17.51%   17.50%   -0.01%     
==========================================
  Files         700      700              
  Lines       10330    10332       +2     
  Branches     1687     1688       +1     
==========================================
  Hits         1809     1809              
- Misses       7089     7090       +1     
- Partials     1432     1433       +1     

Flag	Coverage Δ
#front	12.88% <ø> (ø)
#unit	37.26% <0.00%> (-0.04%)	⬇️

Impacted Files	Coverage Δ
...pe-builder/admin/src/components/ListRow/Wrapper.js	0.00% <ø> (ø)
packages/strapi-plugin-graphql/services/utils.js	34.14% <0.00%> (-1.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3be5e...652fe9a. Read the comment docs.

[derrickmehaffy]

Tests look to be passing now good catch @iicdii

[alexandrebodin]

This change feels like a patch rather than a clean fix to me.
I would like to know why graphqlCtx.context = ctx doesn't work and fix it instead of just patching on element of the context then another one etc

[iicdii]

@alexandrebodin
This is the clue I've found why test fails.

// packages/strapi-plugin-users-permissions/test/graphql.test.e2e.js`

test('createUser is authorized for admins', async () => {
  const res = await authReq({
    url: '/graphql',
    method: 'POST',
    body: {
      query: /* GraphQL */ `
        mutation {
          createUser(
            input: {
              data: {
                username: "test"
                email: "test@strapi.io"
                password: "test"
              }
            }
          ) {
            user {
              id
              username
            }
          }
        }
      `,
    },
  });

  expect(res.statusCode).toBe(201);
  expect(res.body).toMatchObject({
    data: {
      createUser: {
        user: {
          id: expect.anything(),
          username: 'test',
        },
      },
    },
  });

  data.user = res.body.data.createUser.user;
});

res.statusCode is 200 when I graphqlContext.context = ctx so test fails.
Otherwise it's 201 when I graphqlContext.context.state = ctx.state so test passes.
It seems to need more digging the code, honestly I don't get the concept difference between graphqlContext and ctx.

[alexandrebodin]

ctx is the context of the koa app and graphqlContext is the context inside of graphql.

When we receive a graphql query it calls koa middleware hence the need to passe the ctx to them. We just clone it to avoid pbl when running multiple queries at once.

if you look at the createUser mutation you will see it calls a controller with the context and inside of this you have a ctx.created() call. this is supposed to do ctx.status = 201 and ctx.body = data

But this is not copied back to the koa context. Which in my opinion isn't a big deal.

I think we should set graphqlContext.context =. ctx and just change the test to check for a 200 status. In graphql other status don't really make sense anyway.

[iicdii]

Thank you for detailed explanation. I made PR again.

[alexandrebodin]

LGTM

[alexandrebodin]

Thanks you for this PR 💯