Fix deep filtering for manyWay #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
Codecov Report
@@ Coverage Diff @@
## master #5536 +/- ##
===========================================
- Coverage 37.26% 17.50% -19.76%
===========================================
Files 60 700 +640
Lines 1959 10332 +8373
Branches 440 1688 +1248
===========================================
+ Hits 730 1809 +1079
- Misses 916 7090 +6174
- Partials 313 1433 +1120
Continue to review full report at Codecov.
|
alexandrebodin
requested changes
Mar 20, 2020
| ); | ||
| qb.leftJoin( | ||
| `${originInfo.model.databaseName}.${assoc.tableCollectionName} AS ${joinTableAlias}`, | ||
| `${joinTableAlias}.${singular(originInfo.alias)}_id`, |
There was a problem hiding this comment.
Two comments here:
- Test with a manyWay pointing to the same model ;)
- As it is the only change can you refactor the code a bit to avoid repetition :)
There was a problem hiding this comment.
Oh yeah, good catch for related 😏
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
|
I updated the PR. |
|
You should start by splitting the join columns into variables with understadable names and see how you can factor those :) |
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
alexandrebodin
requested changes
Mar 20, 2020
alexandrebodin
added
source: core:database
added 2 commits
March 23, 2020 12:00
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
petersg83
force-pushed
the
fix/#4487/filteringDataManyWayError500
branch
from
d39af72
to
3964804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4487
Description of what you did: