New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix generate:model --plugin path + little refacto of code #5547
fix generate:model --plugin path + little refacto of code #5547
Conversation
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
Codecov Report
@@ Coverage Diff @@
## master #5547 +/- ##
=======================================
Coverage 17.50% 17.51%
=======================================
Files 700 700
Lines 10332 10322 -10
Branches 1688 1686 -2
=======================================
- Hits 1809 1808 -1
+ Misses 7090 7083 -7
+ Partials 1433 1431 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions:
- Why replace deburr by camelCase ? I think this might break when trying to use invalid chars.
- Why use camelCase for the folder names? Why not leave it to the user like before ?
- I think we should move away from the upperFirst(camelCase(x)) formatting for the model filename as we do not generate them like this anymore :)
Thanks !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice try but strapi-utils isn't client-side friendly ;)
packages/strapi-plugin-content-type-builder/admin/src/containers/FormModal/utils/createUid.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-content-type-builder/admin/src/containers/FormModal/utils/forms.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
d919c35
to
74625b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fix #3889
Description of what you did: