Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UID searchable in Mongoose and avoid errors if content type can't be searched #5578

Merged
merged 2 commits into from Mar 23, 2020
Merged

Conversation

diogotcorreia
Copy link
Contributor

Description of what you did:

This PR should fix #5577. This only changes strapi-connector-mongoose and should be ready to be merged.

Signed-off-by: Diogo Correia <me@diogotc.com>
Signed-off-by: Diogo Correia <me@diogotc.com>
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5578 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5578   +/-   ##
=======================================
  Coverage   17.50%   17.50%           
=======================================
  Files         700      700           
  Lines       10332    10332           
  Branches     1688     1688           
=======================================
  Hits         1809     1809           
  Misses       7090     7090           
  Partials     1433     1433           
Flag Coverage Δ
#front 12.88% <ø> (ø)
#unit 37.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826bb8a...400893f. Read the comment docs.

@alexandrebodin alexandrebodin added source: core:database Source is core/database package issue: bug Issue reporting a bug labels Mar 23, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 23, 2020
@alexandrebodin alexandrebodin self-requested a review March 23, 2020 16:40
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the fix 💯

@alexandrebodin alexandrebodin merged commit ce7db06 into strapi:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when searching a content type with no searchable fields or UID
2 participants