Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Updated the 'terms' translations for 'de' #5589

Merged
merged 1 commit into from Mar 27, 2020
Merged

Translations: Updated the 'terms' translations for 'de' #5589

merged 1 commit into from Mar 27, 2020

Conversation

lennartstolz
Copy link
Contributor

@lennartstolz lennartstolz commented Mar 24, 2020

"Terms and Conditions" are called "Allgemeine Geschäftsbedingungen" in German (often abbreviated as "AGB") or "Nutzungsbedingungen".

In the context of the admin sign-up of 'strapi' I'd go for the latter.
(Research results attached to the pull request)

The previous version "Begriffe" is wrong in this context as it is the literal translation of the word "term".

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #5589 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5589   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10322    10322           
  Branches     1686     1686           
=======================================
  Hits         1808     1808           
  Misses       7083     7083           
  Partials     1431     1431           
Flag Coverage Δ
#front 12.88% <0.00%> (ø)
#unit 37.40% <ø> (ø)
Impacted Files Coverage Δ
...ager/admin/src/components/SelectMany/components.js 0.00% <ø> (ø)
...anager/admin/src/components/SelectWrapper/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a5160...b82921a. Read the comment docs.

@lennartstolz lennartstolz changed the title Translations: Updated the 'terms' translations for 'de' WIP: Translations: Updated the 'terms' translations for 'de' Mar 26, 2020
@lennartstolz
Copy link
Contributor Author

I flagged this PR as WIP for now. I did some benchmarking yesterday and realized that maybe Nutzungsbedinungen would be even a better fit for this use case.

I will update the PR this evening and will provide you a bunch of screenshots to verify. :-)

@lennartstolz lennartstolz changed the title WIP: Translations: Updated the 'terms' translations for 'de' Translations: Updated the 'terms' translations for 'de' Mar 27, 2020
@lennartstolz
Copy link
Contributor Author

lennartstolz commented Mar 27, 2020

@alexandrebodin, as promised: here is the research results :-)

  1. Goole Terms & Conditions

signup-google

  1. Sign-Up page of Adobe

signup-adobe

  1. Sign-Up of Facebook

terms-facebook

  1. Sign-Up of SPIEGEL (german newsmagazine)

terms-spiegel

(There are also some platforms using "Allgemeine Geschäftsbedingungen" / "AGB" - but it looks like more and more big players are moving to the term "Nutzungsbedingungen". :-)

"Terms and Conditions" are called "Allgemeine Geschäftsbedingungen" in
German (often abbreviated as "AGB") or "Nutzungsbedingungen".

In the context of the admin sign-up of 'strapi' I'd go for the latter.
(Research results attached to the pull request)

The previous version "Begriffe" is wrong in this context as it is the
literal translation of the word "term".

Signed-off-by: Lennart Stolz <lennartstolz@me.com>
@alexandrebodin alexandrebodin added issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package labels Mar 27, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 27, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thank you for the careful research :)

@alexandrebodin alexandrebodin merged commit 9137233 into strapi:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants