Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #5596

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix typo #5596

merged 1 commit into from Mar 30, 2020

Conversation

yedeyu
Copy link
Contributor

@yedeyu yedeyu commented Mar 25, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited

Codecov Report

Merging #5596 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5596   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10322    10322           
  Branches     1686     1686           
=======================================
  Hits         1808     1808           
  Misses       7083     7083           
  Partials     1431     1431
Flag Coverage Δ
#front 12.88% <ø> (ø)
#unit 37.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63c692...5af9042. Read the comment docs.

soupette
soupette approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to improve the documentation.

@soupette soupette added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 30, 2020
@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 30, 2020
@alexandrebodin alexandrebodin merged commit 9ec7d90 into strapi:master Mar 30, 2020
@yedeyu yedeyu deleted the patch-1 branch March 30, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

@derrickmehaffy derrickmehaffy Awaiting requested review from derrickmehaffy

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Milestone
3.0.0-beta.19.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yedeyu @soupette @alexandrebodin