Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix French trad for float and decimal #5622

Merged
merged 2 commits into from Mar 27, 2020
Merged

Fix French trad for float and decimal #5622

merged 2 commits into from Mar 27, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR corrects the wrong translation of the decimal type.

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-type-builder Source is core/content-type-builder package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 27, 2020
@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 27, 2020
@soupette soupette requested a review from lauriejim March 27, 2020 10:07
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #5622 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5622   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10322    10322           
  Branches     1686     1686           
=======================================
  Hits         1808     1808           
  Misses       7083     7083           
  Partials     1431     1431           
Flag Coverage Δ
#front 12.88% <ø> (ø)
#unit 37.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8de29...c27f9ea. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit fb7e8f3 into master Mar 27, 2020
@alexandrebodin alexandrebodin deleted the fix/ctb-trad branch March 27, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants