Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5573 #5623

Merged
merged 2 commits into from Mar 30, 2020
Merged

Fixes #5573 #5623

merged 2 commits into from Mar 30, 2020

Conversation

dkarski
Copy link
Contributor

@dkarski dkarski commented Mar 27, 2020

Description of what you did:

This PR improves the content manager search for the input by replacing ?_q=5d1 to {mainField}_contains=5d1.

Relative issues:
#5573
#4025

Signed-off-by: Daniel Karski <daniel.karski@polidea.com>
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #5623 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5623      +/-   ##
==========================================
+ Coverage   17.51%   17.52%   +0.01%     
==========================================
  Files         700      700              
  Lines       10322    10316       -6     
  Branches     1686     1685       -1     
==========================================
  Hits         1808     1808              
+ Misses       7083     7078       -5     
+ Partials     1431     1430       -1     
Flag Coverage Δ
#front 12.89% <0.00%> (+<0.01%) ⬆️
#unit 37.40% <ø> (ø)
Impacted Files Coverage Δ
...anager/admin/src/components/SelectWrapper/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7e8f3...d1ee4d3. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to improve the project we really appreciate!

@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Mar 30, 2020
@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 30, 2020
@alexandrebodin alexandrebodin merged commit 3a24755 into strapi:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants