Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed add new entity button to just use getName for consistency (#5… #5633

Merged

Conversation

cacodev
Copy link
Contributor

@cacodev cacodev commented Mar 28, 2020

fixed #5632 by removing the capitalization function. Seems that this was consistent with the rest of the component

…rapi#5632)

Signed-off-by: Casey Collins <4412526+cacodev@users.noreply.github.com>
@cacodev cacodev force-pushed the fix/#5632/entityCasingOnAddNew branch from a7e89b5 to 237b161 Compare March 28, 2020 15:58
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #5633 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5633   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10322    10320    -2     
  Branches     1686     1686           
=======================================
  Hits         1808     1808           
+ Misses       7083     7081    -2     
  Partials     1431     1431           
Flag Coverage Δ
#front 12.88% <0.00%> (+<0.01%) ⬆️
#unit 37.40% <ø> (ø)
Impacted Files Coverage Δ
...ent-manager/admin/src/containers/ListView/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7e8f3...237b161. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added source: core:content-manager Source is core/content-manager package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 30, 2020
@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 30, 2020
@alexandrebodin alexandrebodin merged commit 4a3ebe6 into strapi:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When entity is more than one word, add new entity button should use proper/pascal casing for the entity name
3 participants