CreatedInputEmailWithErrors and associated documentation #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize Inputs*WithErrors props and add noErrorsDescription prop so it can set a spacer in order to keep the input s alignment correct
Aurelsicoko
reviewed
Feb 6, 2018
| } | ||
|
|
||
| handleFocus = (e) => { | ||
| console.log('ok'); |
Aurelsicoko
reviewed
Feb 6, 2018
| } | ||
|
|
||
| validate = (value) => { | ||
| const emailRegex = new RegExp(/^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/); |
There was a problem hiding this comment.
Should we use the strapi-helper-plugin/utils to share this function across the admin panel? I think it would be better instead of repeating this kind of validators everywhere in our codebase.
There was a problem hiding this comment.
Agree I'll move this function in the utils but I prefer to do it once the lib is completely implemented to avoid conflicts and make sure I have all the validations set
Aurelsicoko
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
InputEmailandInputEmailWithErrorscomponentsReorganize Inputs*WithErrors props and add
noErrorsDescriptionprop so it can set a spacer in order to keep the inputs' alignment correct