Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logo_login to local asset #6637

Closed
wants to merge 1 commit into from
Closed

Changed logo_login to local asset #6637

wants to merge 1 commit into from

Conversation

noahmay
Copy link

@noahmay noahmay commented Jun 11, 2020

Description of what you did:

Fixed #6301

Logo on index.html is now local instead of linked to logo_login.png on strapi.io.

derrickmehaffy
derrickmehaffy previously approved these changes Jun 11, 2020
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #6637 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6637   +/-   ##
=======================================
  Coverage   19.85%   19.86%           
=======================================
  Files         857      857           
  Lines       12076    12077    +1     
  Branches     1963     1963           
=======================================
+ Hits         2398     2399    +1     
  Misses       8093     8093           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.67% <100.00%> (+<0.01%) ⬆️
#unit 41.26% <ø> (ø)
Impacted Files Coverage Δ
...admin/src/containers/InstalledPluginsPage/index.js 7.14% <ø> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <ø> (ø)
...in-content-manager/admin/src/translations/index.js 0.00% <ø> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <ø> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <ø> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <ø> (ø)
...i-admin/admin/src/containers/LocaleToggle/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2243af...59413d8. Read the comment docs.

Signed-off-by: Noah Mayerhofer <noah.mayerhofer@hotmail.com>
@petersg83
Copy link
Contributor

petersg83 commented Jun 15, 2020

Hi,
Thanks for your contribution!
It doesn't seem to work on my side:
Capture d’écran 2020-06-15 à 10 12 40

Am I missing something? @derrickmehaffy did you launch it?

@alexandrebodin
Copy link
Member

Closing in favor of #6764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logo_login.jpg points to strapi.io not local asset
4 participants