Allow name edition in CE #7046
Merged
Allow name edition in CE #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupette
force-pushed
the
fix/ce-allow-role-name-edition
branch
from
49d9920
to
56b46a5
Compare
petersg83
suggested changes
Jul 17, 2020
Codecov Report
|
soupette
force-pushed
the
fix/ce-allow-role-name-edition
branch
from
56b46a5
to
ec3147b
Compare
|
LGTM :) |
petersg83
approved these changes
Jul 17, 2020
Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette
force-pushed
the
fix/ce-allow-role-name-edition
branch
from
ec3147b
to
11afd28
Compare
|
I think we need to do sth in case we rename the Super Admin role, the error messages that say you need to have at least one super admin won't make much sense. |
|
You are right @alexandrebodin, in my opinion and for consistency matters, we should prevent only the Super Admin renaming from the Admin Panel (it would still be possible in DB). |
|
I agree @JabStrapi |
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette
force-pushed
the
fix/ce-allow-role-name-edition
branch
from
71d9284
to
9ba69f6
Compare
…rapi into fix/ce-allow-role-name-edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: soupette cyril.lpz@gmail.com
Description of what you did:
Allow role name edition for CE.