Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license info #7084

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Update license info #7084

merged 1 commit into from
Jul 20, 2020

Conversation

alexandrebodin
Copy link
Member

Change License links

@alexandrebodin
Update license info
62b2192 
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
petersg83
petersg83 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

derrickmehaffy
derrickmehaffy approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though the license key in the package.json files may throw some automated systems for a loop.

Any reason we changed the file name from LICENSE.md to LICENSE?

docs/package.json
@@ -6,7 +6,7 @@
"dev": "vuepress dev",
"build": "vuepress build"
},
"license": "MIT",
"license": "SEE LICENSE IN LICENSE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention the EE license for the docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to see with sales for this ;) not urgent I think. WIll setup CLA too and improve the contributing guide I think

and FYI, it was for a legal stuff that I got asked to remove the md. No idea why atm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 interesting, noted.

@alexandrebodin alexandrebodin merged commit e0ee773 into features/rbac Jul 20, 2020
@alexandrebodin alexandrebodin deleted the chore/update-license-info branch July 20, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

@petersg83 petersg83 petersg83 approved these changes

@lauriejim lauriejim Awaiting requested review from lauriejim

@soupette soupette Awaiting requested review from soupette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexandrebodin @derrickmehaffy @petersg83