-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration documentation #7282
Conversation
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Bumps [koa-session](https://github.com/koajs/session) from 5.13.1 to 6.0.0. - [Release notes](https://github.com/koajs/session/releases) - [Changelog](https://github.com/koajs/session/blob/master/History.md) - [Commits](koajs/session@5.13.1...6.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Cleanup shelljs
fix regression issue due to pull #7204 Signed-off-by: Akash P <aksdevac@gmail.com>
Fix #7252: fix relation name
Please review the architecture of the Integrations.
|
Codecov Report
@@ Coverage Diff @@
## documentation #7282 +/- ##
=================================================
+ Coverage 19.14% 26.17% +7.03%
=================================================
Files 855 1130 +275
Lines 11933 15414 +3481
Branches 1898 2439 +541
=================================================
+ Hits 2284 4034 +1750
- Misses 8100 9561 +1461
- Partials 1549 1819 +270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@lauriejim I'm wondering if it would be better to offload all the svgs to files and import them (just to keep the inline html cleaner and easier to read) (for all of them not just here) |
Good for the structure 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great initial start, just a few small things I noticed.
Something else we should look at is give a bit more describing text and not just code samples. It will probably also be worth diving deeper into more of the content API topics relating to other types of requests (PUT, POST, DELETE) and query parameters and filtering.
Made some modifications @derrickmehaffy @soupette |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nice @Mcastres 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When do you think this PR can be merged? @lauriejim? |
Give me another day @Mcastres to review how it looks locally and I'll redo my review (just want to review the english grammar as well to make sure we don't miss anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mcastres let me know when you are ready for a merge et deploy.
This looks good to me (sorry forgot to respond) very well done @Mcastres |
You can merge @lauriejim |
Description of what you did: