New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FluidContainer: Fix overlapping on pagination tab #7289
Conversation
Signed-off-by: Manoj P <thedarkstrix@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7289 +/- ##
==========================================
- Coverage 26.17% 26.17% -0.01%
==========================================
Files 1130 1130
Lines 15413 15414 +1
Branches 2439 2439
==========================================
Hits 4034 4034
- Misses 9560 9561 +1
Partials 1819 1819
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@soupette Hi, I think this should be reviewed again, as it might add unnecessary scorll in admin with Also this pull request is not even fixing this issue, it is fixing if I edit padding in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Manoj P <thedarkstrix@gmail.com> Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
Fix : #7265
I have just extended the bottom padding , so that there is room for scrolling down to access the pagination tab.
Before :
After :