Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidContainer: Fix overlapping on pagination tab #7289

Merged
merged 1 commit into from Sep 4, 2020

Conversation

TheDarkStrix
Copy link
Contributor

@TheDarkStrix TheDarkStrix commented Aug 1, 2020

Fix : #7265

I have just extended the bottom padding , so that there is room for scrolling down to access the pagination tab.

Before :
image

After :

image

Signed-off-by: Manoj P <thedarkstrix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #7289 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7289      +/-   ##
==========================================
- Coverage   26.17%   26.17%   -0.01%     
==========================================
  Files        1130     1130              
  Lines       15413    15414       +1     
  Branches     2439     2439              
==========================================
  Hits         4034     4034              
- Misses       9560     9561       +1     
  Partials     1819     1819              
Flag Coverage Δ
#front 18.27% <0.00%> (-0.01%) ⬇️
#unit 52.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/admin/src/components/ContainerFluid/index.js 66.66% <ø> (ø)
...min/src/containers/Onboarding/StaticLinks/index.js 0.00% <0.00%> (ø)
...ntent-manager/admin/src/components/Inputs/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97922f9...3172b42. Read the comment docs.

soupette
soupette previously approved these changes Aug 3, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added source: core:admin Source is core/admin package issue: bug Issue reporting a bug labels Aug 3, 2020
@soupette soupette added this to the 3.1.4 milestone Aug 3, 2020
@imaksp
Copy link
Contributor

imaksp commented Aug 4, 2020

@soupette Hi, I think this should be reviewed again, as it might add unnecessary scorll in admin with SHOW_TUTORIALS = false
https://strapi.io/documentation/v3.x/admin-panel/customization.html#development-mode
issue-scroll

Also this pull request is not even fixing this issue, it is fixing if I edit padding in strapi-plugin-content-manager/admin/src/components/Container/index.js so this is not the correct file.

@soupette soupette removed this from the 3.1.4 milestone Aug 11, 2020
@alexandrebodin alexandrebodin modified the milestone: 3.1.4 Aug 12, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"help button" on bottom right cover the pagination button
6 participants