Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strapi requires NodeJS between equals or greater than 10.16 and equals or less than 14 #8446

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

bykof
Copy link
Contributor

@bykof bykof commented Oct 22, 2020

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #8446 into master will increase coverage by 21.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8446       +/-   ##
===========================================
+ Coverage   33.27%   54.63%   +21.35%     
===========================================
  Files        1220      118     -1102     
  Lines       13625     3895     -9730     
  Branches     1357      799      -558     
===========================================
- Hits         4534     2128     -2406     
+ Misses       8207     1382     -6825     
+ Partials      884      385      -499     
Flag Coverage Δ
#front ?
#unit 54.63% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-utils/lib/models.js 24.69% <0.00%> (-0.31%) ⬇️
...manager/admin/src/components/SortableList/index.js
...lder/admin/src/components/RelationFormBox/index.js
...dmin/src/components/LeftMenu/LeftMenuLink/index.js
...pload/admin/src/components/InputFileModal/index.js
...e-builder/admin/src/components/BooleanBox/Label.js
...ilder/admin/src/components/SelectCheckbox/index.js
...rc/containers/AuthPage/components/Section/index.js
...pload/admin/src/components/VideoPreview/Wrapper.js
...i-admin/admin/src/containers/Onboarding/reducer.js
... and 1093 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838b8ac...476af37. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@alexandrebodin alexandrebodin merged commit 2f54d71 into strapi:master Oct 22, 2020
pascalvaccaro pushed a commit to pascalvaccaro/strapi that referenced this pull request Oct 29, 2020
petersg83 pushed a commit that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants