Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strapi-provider-email-mailgun: updates documentation #8891

Merged
merged 7 commits into from Dec 18, 2020

Conversation

meck93
Copy link
Contributor

@meck93 meck93 commented Dec 14, 2020

Signed-off-by: Moritz Eck moritz.eck@gmail.com

What does it do?

  • updates the documentation

Why is it needed?

  • Saves users with a European mailgun host some time during the setup and the integration.

Related issue(s)/PR(s)

  • None, I noticed it when I tried to use the mailgun email provider.

Signed-off-by: Moritz Eck <moritz.eck@gmail.com>
@strapi-cla
Copy link

strapi-cla commented Dec 14, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #8891 (719e5e6) into master (f67b519) will increase coverage by 1.08%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8891      +/-   ##
==========================================
+ Coverage   33.47%   34.56%   +1.08%     
==========================================
  Files        1249     1307      +58     
  Lines       13747    14355     +608     
  Branches     1367     1419      +52     
==========================================
+ Hits         4602     4962     +360     
- Misses       8255     8484     +229     
- Partials      890      909      +19     
Flag Coverage Δ
front 26.02% <4.33%> (+0.94%) ⬆️
unit 55.05% <52.27%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pi-admin/admin/src/components/GlobalStyle/index.js 0.00% <ø> (ø)
...in/admin/src/components/LeftMenu/LeftMenuLink/A.js 22.22% <ø> (ø)
...s/LeftMenu/LeftMenuLinkSection/LeftMenuListLink.js 100.00% <ø> (ø)
.../Permissions/ContentTypes/ContentTypesRow/index.js 0.00% <ø> (ø)
...c/components/Roles/Permissions/utils/tests/data.js 100.00% <ø> (ø)
...src/components/Users/ModalCreateBody/utils/form.js 100.00% <ø> (ø)
...c/containers/AuthPage/components/AuthLink/index.js 0.00% <0.00%> (ø)
...ainers/AuthPage/components/ForgotPassword/index.js 0.00% <0.00%> (ø)
...AuthPage/components/ForgotPasswordSuccess/index.js 0.00% <0.00%> (ø)
.../src/containers/AuthPage/components/Login/index.js 0.00% <0.00%> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1c2f...12932fd. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need this changes made here soon as we are moving our documentation to a new repo. If you are unable to make the changes in the next few hours, I will close this and make the changes on our new repo here: https://github.com/strapi/documentation

packages/strapi-provider-email-mailgun/README.md Outdated Show resolved Hide resolved
packages/strapi-provider-email-mailgun/README.md Outdated Show resolved Hide resolved
Signed-off-by: Moritz Eck <moritz.eck@gmail.com>
@meck93
Copy link
Contributor Author

meck93 commented Dec 15, 2020

Hi @derrickmehaffy, thanks for the review. I have updated the documentation according to your feedback.

Signed-off-by: Moritz Eck <moritz.eck@gmail.com>
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy
Copy link
Member

Pending tests then good to merge

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Dec 18, 2020
@alexandrebodin alexandrebodin added this to the 3.4.1 milestone Dec 18, 2020
@alexandrebodin alexandrebodin merged commit 171a56b into strapi:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants