Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwray-tech/update plugin descriptions #8921

Merged

Conversation

cwray-tech
Copy link
Contributor

What does it do?

This is just adding some simple plugin descriptions as originally discussed on this pr: #8254

I simply updated the descriptions in the package.json files.

Why is it needed?

This is needed because it will be more accurate descriptions of the plugins in places where these descriptions are used.

The marketplace area in the cms shows this text, so I thought this would be a little more helpful than the default text.

Signed-off-by: Christopher Wray <53663762+cwray-tech@users.noreply.github.com>
@cwray-tech
Copy link
Contributor Author

@alexandrebodin Love it if you could check this out and merge before next update haha.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #8921 (28aad94) into master (f67b519) will increase coverage by 1.08%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8921      +/-   ##
==========================================
+ Coverage   33.47%   34.56%   +1.08%     
==========================================
  Files        1249     1307      +58     
  Lines       13747    14355     +608     
  Branches     1367     1419      +52     
==========================================
+ Hits         4602     4962     +360     
- Misses       8255     8484     +229     
- Partials      890      909      +19     
Flag Coverage Δ
front 26.02% <4.33%> (+0.94%) ⬆️
unit 55.05% <52.27%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pi-admin/admin/src/components/GlobalStyle/index.js 0.00% <ø> (ø)
...in/admin/src/components/LeftMenu/LeftMenuLink/A.js 22.22% <ø> (ø)
...s/LeftMenu/LeftMenuLinkSection/LeftMenuListLink.js 100.00% <ø> (ø)
.../Permissions/ContentTypes/ContentTypesRow/index.js 0.00% <ø> (ø)
...c/components/Roles/Permissions/utils/tests/data.js 100.00% <ø> (ø)
...src/components/Users/ModalCreateBody/utils/form.js 100.00% <ø> (ø)
...c/containers/AuthPage/components/AuthLink/index.js 0.00% <0.00%> (ø)
...ainers/AuthPage/components/ForgotPassword/index.js 0.00% <0.00%> (ø)
...AuthPage/components/ForgotPasswordSuccess/index.js 0.00% <0.00%> (ø)
.../src/containers/AuthPage/components/Login/index.js 0.00% <0.00%> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7c827...2dcba76. Read the comment docs.

@cwray-tech
Copy link
Contributor Author

Actually, Scratch that? some of the linting tests didn't pass. I will keep this fork active this time, so no pressure to quickly merge! @alexandrebodin

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement :)

@alexandrebodin alexandrebodin added this to the 3.4.1 milestone Dec 18, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels Dec 18, 2020
@alexandrebodin alexandrebodin merged commit 99d39f5 into strapi:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants