Fix inputs display #8935
Fix inputs display #8935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8935 +/- ##
==========================================
- Coverage 34.63% 26.02% -8.62%
==========================================
Files 1308 1176 -132
Lines 14371 10128 -4243
Branches 1420 562 -858
==========================================
- Hits 4978 2636 -2342
+ Misses 8484 6993 -1491
+ Partials 909 499 -410
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette
added
source: core:content-manager
| @@ -118,7 +118,7 @@ function ListView({ | |||
| const [isFilterPickerOpen, setFilterPickerState] = useState(false); | |||
| const [idToDelete, setIdToDelete] = useState(null); | |||
| const contentType = layout.contentType; | |||
| const hasDraftAndPublish = contentType.options.draftAndPublish; | |||
| const hasDraftAndPublish = contentType.options.draftAndPublish || false; | |||
There was a problem hiding this comment.
The get function of lodash is already imported in this file. Can you use it here, please?
const hasDraftAndPublish = get(contentType, ['options', 'draftAndPublish'], false);
| generateUid.current(true); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); |
There was a problem hiding this comment.
I don't understand why this is removed? The UID has to be generated if the field is required.
There was a problem hiding this comment.
Because when updating a document the field gets regenerated, this solves the issue.
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette cyril.lpz@gmail.com
What does it do?
We need to make a stable release of Buffet.js before merging this PR.
This PR fixes: