Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry on the relational field feature #8937

Merged
merged 4 commits into from Dec 21, 2020
Merged

Conversation

petersg83
Copy link
Contributor

No description provided.

@petersg83 petersg83 changed the title add didConfigureListView Add telemetry on the relational field feature Dec 18, 2020
@petersg83 petersg83 added source: core:content-manager Source is core/content-manager package issue: enhancement Issue suggesting an enhancement to an existing feature labels Dec 18, 2020
@petersg83 petersg83 added this to the 3.4.1 milestone Dec 18, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #8937 (ae5edd3) into master (f67b519) will increase coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8937      +/-   ##
==========================================
+ Coverage   33.47%   34.63%   +1.16%     
==========================================
  Files        1249     1308      +59     
  Lines       13747    14371     +624     
  Branches     1367     1420      +53     
==========================================
+ Hits         4602     4978     +376     
- Misses       8255     8484     +229     
- Partials      890      909      +19     
Flag Coverage Δ
front 26.02% <ø> (+0.94%) ⬆️
unit 55.22% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/admin/src/components/BaselineAlignement/index.js 0.00% <0.00%> (-42.86%) ⬇️
...t-manager/admin/src/containers/ListView/reducer.js 65.78% <0.00%> (-27.32%) ⬇️
...iners/SettingsPage/components/MenuWrapper/index.js 50.00% <0.00%> (-16.67%) ⬇️
packages/strapi-utils/lib/content-types.js 91.66% <0.00%> (-5.31%) ⬇️
packages/strapi/lib/services/entity-service.js 44.44% <0.00%> (-4.34%) ⬇️
...in-content-manager/controllers/validation/index.js 41.37% <0.00%> (-3.63%) ⬇️
packages/strapi-utils/lib/build-query.js 20.31% <0.00%> (-2.77%) ⬇️
...dmin/admin/src/components/Roles/EmptyRole/index.js 83.33% <0.00%> (-2.39%) ⬇️
...ages/strapi/lib/services/entity-validator/index.js 53.57% <0.00%> (-1.61%) ⬇️
...admin/admin/src/containers/Roles/EditPage/index.js 57.69% <0.00%> (-1.57%) ⬇️
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171a56b...ae5edd3. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants