Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instagram login after instagram API changed #9101

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Fix instagram login after instagram API changed #9101

merged 2 commits into from
Jan 18, 2021

Conversation

petersg83
Copy link
Contributor

fix #9036

@petersg83 petersg83 added this to the 3.4.2 milestone Jan 12, 2021
@petersg83 petersg83 added source: plugin:users-permissions Source is plugin/users-permissions package issue: bug Issue reporting a bug labels Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited

Codecov Report

Merging #9101 (fb785e4) into master (5f87279) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9101   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
  Hits         4999     4999           
  Misses       8518     8518           
  Partials      914      914
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3d100...fb785e4. Read the comment docs.

@petersg83 petersg83 added the flag: don't merge This PR should not be merged at the moment label Jan 13, 2021
@petersg83
Copy link
Contributor Author

I'll update the PR since purest-providers was updated few minutes ago :)

@alexandrebodin alexandrebodin removed this from the 3.4.2 milestone Jan 13, 2021
@petersg83 petersg83 removed the flag: don't merge This PR should not be merged at the moment label Jan 13, 2021
@petersg83 petersg83 added this to the 3.4.3 milestone Jan 13, 2021
@alexandrebodin alexandrebodin removed this from the 3.4.3 milestone Jan 14, 2021
@petersg83 petersg83 added this to the 3.4.4 milestone Jan 14, 2021
@alexandrebodin alexandrebodin added the flag: migration guide This PR introduces changes that require a migration guide label Jan 18, 2021
alexandrebodin
alexandrebodin approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexandrebodin alexandrebodin merged commit 21ebe0d into master Jan 18, 2021
@alexandrebodin alexandrebodin deleted the fix/instagram-login branch January 18, 2021 13:53
@renovate renovate bot mentioned this pull request Jun 14, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@Convly Convly Awaiting requested review from Convly

Assignees
No one assigned
Labels
flag: migration guide This PR introduces changes that require a migration guide issue: bug Issue reporting a bug source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Milestone
3.4.4
Development

Successfully merging this pull request may close these issues.

Instagram OAuth provider is broken
2 participants
@petersg83 @alexandrebodin