Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortable config disabled at launch #9115

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

petersg83
Copy link
Contributor

@petersg83 petersg83 commented Jan 13, 2021

Sortable param was set to false for relational fields when restarting the app

fixes #9099

@petersg83 petersg83 added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Jan 13, 2021
@petersg83 petersg83 added this to the 3.4.3 milestone Jan 13, 2021
@petersg83 petersg83 changed the title Fix/sortable config disabled at launch Fix sortable config disabled at launch Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #9115 (707c56b) into master (5f87279) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9115   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
+ Hits         4999     5000    +1     
+ Misses       8518     8517    -1     
  Partials      914      914           
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/services/utils/configuration/attributes.js 57.83% <100.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7505de6...707c56b. Read the comment docs.

@derrickmehaffy
Copy link
Member

Fix works but it does dump the following warning to the console:

[2021-01-13T15:07:39.020Z] warn Deep filtering queries should be used carefully (e.g Can cause performance issues).

@alexandrebodin
Copy link
Member

Fix works but it does dump the following warning to the console:

[2021-01-13T15:07:39.020Z] warn Deep filtering queries should be used carefully (e.g Can cause performance issues).

When do you get this message ?

@alexandrebodin
Copy link
Member

Waiting for the explanation on the deep filtering message before merging @derrickmehaffy @petersg83

@alexandrebodin alexandrebodin removed this from the 3.4.3 milestone Jan 14, 2021
@petersg83
Copy link
Contributor Author

Yep :) It's when you sort by a RF just. It's not specific to this PR

@alexandrebodin alexandrebodin added this to the 3.4.4 milestone Jan 14, 2021
@alexandrebodin alexandrebodin merged commit 1e8a8b0 into master Jan 14, 2021
@alexandrebodin alexandrebodin deleted the fix/sortable-config-disabled-at-launch branch January 14, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Enable sort on this field" is getting reset after restart
3 participants