Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST api for content-types that start with "admin" #9128

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

petersg83
Copy link
Contributor

fix #9017

@petersg83 petersg83 added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Jan 14, 2021
@petersg83 petersg83 added this to the 3.4.4 milestone Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #9128 (a9a238b) into master (df33626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9128   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
+ Hits         4999     5000    +1     
+ Misses       8518     8517    -1     
  Partials      914      914           
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/services/utils/configuration/attributes.js 57.83% <100.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8a8b0...9edb3b0. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a fresh v3.4.3 with the modifications applied. Works as expected

@alexandrebodin alexandrebodin merged commit 23d41fd into master Jan 18, 2021
@petersg83 petersg83 deleted the fix/rest-api-ct-beginning-with-admin branch August 23, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access route with prefix 'admin'
3 participants