Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German translations #9141

Merged
merged 13 commits into from
Jan 18, 2021
Merged

Update German translations #9141

merged 13 commits into from
Jan 18, 2021

Conversation

pr0gr8mm3r
Copy link
Contributor

What does it do?

fixes typos, makes translations more concise and consistent

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #9141 (27ac650) into master (9fd22a9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9141   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
  Hits         5000     5000           
  Misses       8517     8517           
  Partials      914      914           
Flag Coverage Δ
front 26.04% <0.00%> (ø)
unit 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntent-manager/admin/src/components/Search/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ebe0d...27ac650. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution ! Just one comment before we can merge this :)

@pr0gr8mm3r
Copy link
Contributor Author

pr0gr8mm3r commented Jan 18, 2021

Thanks for your feedback. I changed Kai Doe, because only very few people, especially those with little knowledge in English, get that this is a standard placeholder name. Even I, who would consider myself as having above average knowledge had to google it first (I of course had a rough idea based on the context the name is used in).
More information here. The article also talks about Erika Mustermann, that name is more commonly used on identification cards and other official documents, and less in UIs.
After a bit of searching I haven't found a gender neutral version, seems like it doesn't exist (yet).

@alexandrebodin
Copy link
Member

Thanks for your feedback. I changed Kai Doe, because only very few people, especially those with little knowledge in English, get that this is a standard placeholder name. Even I, who would consider myself as having above average knowledge had to google it first (I of course had a rough idea based on the context the name is used in).
More information here. The article also talks about Erika Mustermann, that name is more commonly used on identification cards and other official documents, and less in UIs.
After a bit of searching I haven't found a gender neutral version, seems like it doesn't exist (yet).

For now we will keep kai so we have a gender neutral name :& it makes it easier for us to maintain if the email is always the same. I agree with the possible language confusions so if we starting see this as a pain we will reconsider :)

@alexandrebodin alexandrebodin added this to the 3.4.4 milestone Jan 18, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you fro the fixes ! :D will merge as soon as the test pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants