-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update German translations #9141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9141 +/- ##
=======================================
Coverage 34.64% 34.64%
=======================================
Files 1308 1308
Lines 14431 14431
Branches 1432 1432
=======================================
Hits 5000 5000
Misses 8517 8517
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution ! Just one comment before we can merge this :)
packages/strapi-plugin-users-permissions/admin/src/translations/de.json
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-users-permissions/admin/src/translations/de.json
Outdated
Show resolved
Hide resolved
Thanks for your feedback. I changed Kai Doe, because only very few people, especially those with little knowledge in English, get that this is a standard placeholder name. Even I, who would consider myself as having above average knowledge had to google it first (I of course had a rough idea based on the context the name is used in). |
For now we will keep kai so we have a gender neutral name :& it makes it easier for us to maintain if the email is always the same. I agree with the possible language confusions so if we starting see this as a pain we will reconsider :) |
packages/strapi-plugin-users-permissions/admin/src/translations/de.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you fro the fixes ! :D will merge as soon as the test pass
What does it do?
fixes typos, makes translations more concise and consistent