Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing SQLite3 issue on windows #9142

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Jan 15, 2021

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

What does it do?

Forced SQLite3 v5.0.0 instead of ^5.0.0

Why is it needed?

Fixes issue for Windows users and an issue with SQLite3 v5.0.1

Related issue(s)/PR(s)

fixes #9120
TryGhost/node-sqlite3#1424

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added the issue: bug Issue reporting a bug label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #9142 (14f97ba) into master (9fd22a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9142   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
  Hits         5000     5000           
  Misses       8517     8517           
  Partials      914      914           
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82380da...9488a1d. Read the comment docs.

@alexandrebodin alexandrebodin added the source: core:database Source is core/database package label Jan 18, 2021
@alexandrebodin alexandrebodin added this to the 3.4.4 milestone Jan 20, 2021
@alexandrebodin alexandrebodin merged commit 438921e into master Jan 20, 2021
@alexandrebodin alexandrebodin deleted the fix/issue/9120 branch January 20, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strapi not installing with yarn create strapi-app my-project --quickstart
2 participants