Fix error with polymorphic relations when the attribute name is different to related

[germangonzo]

What does it do?

Use the polymorphic attribute info to name the type field correctly.

Currently, It is hardcoded to related_type

Why is it needed?

Fix error with polymorphic relations when the attribute name is different to related

Related issue(s)/PR(s)

Look at the last comment of the issue
#5348

[strapi-cla]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #9396 (c0e147e) into master (afaf111) will increase coverage by 0.04%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #9396      +/-   ##
==========================================
+ Coverage   35.07%   35.12%   +0.04%     
==========================================
  Files        1308     1310       +2     
  Lines       14465    14535      +70     
  Branches     1439     1453      +14     
==========================================
+ Hits         5074     5105      +31     
- Misses       8481     8514      +33     
- Partials      910      916       +6     

Flag	Coverage Δ
front	26.65% <0.00%> (ø)
unit	54.71% <75.00%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...strapi-admin/admin/src/containers/Admin/Wrapper.js	66.66% <ø> (ø)
...anager/admin/src/components/SelectWrapper/index.js	0.00% <ø> (ø)
...ssions/admin/src/components/Policies/Components.js	0.00% <0.00%> (ø)
...permissions/admin/src/components/Policies/index.js	0.00% <0.00%> (ø)
packages/strapi-utils/lib/sanitize-entity.js	97.10% <71.42%> (-2.90%)	⬇️
packages/strapi/lib/middlewares/session/index.js	39.28% <100.00%> (ø)
...rapi/lib/core/app-configuration/config-provider.js	70.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5da26...c0e147e. Read the comment docs.

[alexandrebodin]

Thank you for this fix 💯
A few notes

• We need to make sure the behaviour is the same on mongo before merging
• To avoid unintended issues can you add a e2e test with a polymorphic model using this fix ?

[germangonzo]

Thanks for reviewing the PR *@alexandrebodin* - We need to make sure the behaviour is the same on mongo before merging => The e2e test would validate that, right?

…

On Mon, Feb 15, 2021 at 3:09 AM Alexandre BODIN ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thank you for this fix 💯 A few notes - We need to make sure the behaviour is the same on mongo before merging - To avoid unintended issues can you add a e2e test with a polymorphic model using this fix ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9396 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQBRDGZQTV3CS4LT2B5O3S7DJEFANCNFSM4XS445DA> .

-- Cordialmente, German Andrés González Avellaneda Tel Movil: 3012315971

[alexandrebodin]

Hi @germangonzo did you have time to work on the changes ?

[germangonzo]

Hi @germangonzo did you have time to work on the changes ?

Unfortunately, no. I've been pretty busy these weeks