-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug that wasn't enabling to click behind notification div #9562
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9562 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 1342 1342
Lines 14809 14809
Branches 1476 1476
=======================================
Hits 5314 5314
Misses 8576 8576
Partials 919 919
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, can you apply the requested changes so we can merge your PR?
packages/strapi-admin/admin/src/components/Notifications/NotificationsContainer/Wrapper.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requested change done @soupette @HichamELBSI , thank you for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution!
What does it do?
Fix a bug that when a notification is showing on screen, you can't click in anything that is behind the invisible fixed div.
Why is it needed?
To click on anything that is behing the invisible div, like the first collection
How to test it?
Run the strapi with a notification on
Video
wta93dztQl.mp4