Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that wasn't enabling to click behind notification div #9562

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

yuriburk
Copy link
Contributor

@yuriburk yuriburk commented Mar 2, 2021

What does it do?

Fix a bug that when a notification is showing on screen, you can't click in anything that is behind the invisible fixed div.

Why is it needed?

To click on anything that is behing the invisible div, like the first collection

How to test it?

Run the strapi with a notification on

Video

wta93dztQl.mp4

@strapi-cla
Copy link

strapi-cla commented Mar 2, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #9562 (f9f2a59) into master (fcc409d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9562   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files        1342     1342           
  Lines       14809    14809           
  Branches     1476     1476           
=======================================
  Hits         5314     5314           
  Misses       8576     8576           
  Partials      919      919           
Flag Coverage Δ
front 27.25% <ø> (ø)
unit 55.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/Notifications/NotificationsContainer/Wrapper.js 0.00% <ø> (ø)
...s/NewNotification/Notification/styledComponents.js 0.00% <ø> (ø)
...in/admin/src/containers/NewNotification/Wrapper.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc409d...0910462. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, can you apply the requested changes so we can merge your PR?

HichamELBSI
HichamELBSI previously approved these changes Mar 8, 2021
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriburk
Copy link
Contributor Author

yuriburk commented Mar 9, 2021

Requested change done @soupette @HichamELBSI , thank you for the review

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for your contribution!

@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: bug Issue reporting a bug labels Mar 11, 2021
@alexandrebodin alexandrebodin added this to the 3.5.3 milestone Mar 11, 2021
@alexandrebodin alexandrebodin merged commit 87900d7 into strapi:master Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants