Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gql dz #9660

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix/gql dz #9660

merged 1 commit into from
Mar 10, 2021

Conversation

alexandrebodin
Copy link
Member

Should fix #9451

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #9660 (3502198) into master (13d3ee8) will increase coverage by 19.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9660       +/-   ##
===========================================
+ Coverage   35.98%   55.54%   +19.56%     
===========================================
  Files        1337      142     -1195     
  Lines       14768     4517    -10251     
  Branches     1475      910      -565     
===========================================
- Hits         5314     2509     -2805     
+ Misses       8536     1583     -6953     
+ Partials      918      425      -493     
Flag Coverage Δ
front ?
unit 55.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/strapi-utils/lib/convert-rest-query-params.js 94.59% <ø> (ø)
packages/strapi/lib/services/metrics/index.js 65.00% <ø> (ø)
...issions/utils/getCreateActionsSizeByContentType.js
...tent-type-builder/admin/src/components/Td/index.js
...es/strapi-plugin-upload/admin/src/utils/getType.js
...min/src/containers/EditSettingsView/utils/index.js
.../admin/src/components/RelationPreviewList/index.js
...dmin/src/containers/EditView/Header/utils/index.js
...in/src/containers/Roles/ProtectedEditPage/index.js
...nt-manager/admin/src/components/Truncated/index.js
... and 1182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0637e...adf167b. Read the comment docs.

@alexandrebodin alexandrebodin removed the request for review from petersg83 March 10, 2021 09:45
@Convly Convly self-requested a review March 10, 2021 09:45
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.5.3 milestone Mar 10, 2021
@alexandrebodin alexandrebodin merged commit b363596 into master Mar 10, 2021
@alexandrebodin alexandrebodin deleted the fix/gql-dz branch March 10, 2021 09:46
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic zone content missing in API
3 participants