New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LeftMenuFooter style #996
Conversation
Hi @XcrossD I tried your solution but it doesn't solve #992. Hi suggest the following modifications : Path - function LeftMenuFooter({ version }) { // eslint-disable-line react/prefer-stateless-function
return (
<div className={styles.leftMenuFooter}>
<div>
<FormattedMessage {...messages.poweredBy} />
<a href="https://strapi.io" target="_blank">v{version}</a>
</div>
<LocaleToggle />
</div>
);
} Then in the
|
So is there anything I could do here? If you're moving the flag to the top right corner I don't see the point of adding a commit for the suggestions made by @soupette. Sorry, I didn't help much. |
@XcrossD We should keep your solution right now. It will be temporary but it will fix the issue. Then, we will put the select language in the header. However, it hasn't been validated, it just a quick proposal that I'm making here. |
@XcrossD do you mind updating your PR or do you want me to take care of it? |
@soupette PR added. I was busy producing some debug information for some other issues. |
Thank you for this contribution @XcrossD |
I could not reproduce, but this should fix #992. Not accounting for the padding on each side which causes the footer to go out of bounds should be the problem here.