Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LeftMenuFooter style #996

Merged
merged 6 commits into from Apr 24, 2018
Merged

Update LeftMenuFooter style #996

merged 6 commits into from Apr 24, 2018

Conversation

XcrossD
Copy link
Contributor

@XcrossD XcrossD commented Apr 23, 2018

I could not reproduce, but this should fix #992. Not accounting for the padding on each side which causes the footer to go out of bounds should be the problem here.

@soupette
Copy link
Contributor

Hi @XcrossD I tried your solution but it doesn't solve #992.

Hi suggest the following modifications :

Path - packages/strapi-admin/admin/src/components/LeftMenuFooter/index.js

function LeftMenuFooter({ version }) { // eslint-disable-line react/prefer-stateless-function
  return (
    <div className={styles.leftMenuFooter}>
      <div>
        <FormattedMessage {...messages.poweredBy} />
        <a href="https://strapi.io" target="_blank">v{version}</a>
      </div>
      <LocaleToggle />
    </div>
  );
}

Then in the styles.scss file

// Import
@import "../../styles/variables/variables";

.leftMenuFooter { /* stylelint-disable */
  position: absolute;
  width: 100%;
  bottom: 0;
  height: 3rem;
  
  // New properties
  display: flex;
  justify-content: space-between;

  padding-left: 15px;
  padding-right: 15px;
  line-height: 3rem;
  font-family: 'Lato';
  background-color: rgba(255, 255, 255, .02);
  font-size: 1rem;
  font-weight: 400;
  letter-spacing: 0.05rem;
  vertical-align: middle;
  color: $strapi-gray-light;

  a {
    color: #0097f7;
  }

  select{
    outline: none;
  }
}

@Aurelsicoko
Copy link
Member

I'll certainly make some changes and move the flag in the header instead of the menu. It will be more visible and will avoid this issue.

screen shot 2018-04-23 at 18 11 26

@XcrossD
Copy link
Contributor Author

XcrossD commented Apr 24, 2018

So is there anything I could do here? If you're moving the flag to the top right corner I don't see the point of adding a commit for the suggestions made by @soupette. Sorry, I didn't help much.

@Aurelsicoko
Copy link
Member

@XcrossD We should keep your solution right now. It will be temporary but it will fix the issue. Then, we will put the select language in the header. However, it hasn't been validated, it just a quick proposal that I'm making here.

Aurelsicoko
Aurelsicoko previously approved these changes Apr 24, 2018
@Aurelsicoko Aurelsicoko dismissed their stale review April 24, 2018 09:32

We should use @soupette solution

@soupette
Copy link
Contributor

@XcrossD do you mind updating your PR or do you want me to take care of it?

@XcrossD
Copy link
Contributor Author

XcrossD commented Apr 24, 2018

@soupette PR added. I was busy producing some debug information for some other issues.

@lauriejim
Copy link
Contributor

Thank you for this contribution @XcrossD

@lauriejim lauriejim merged commit 8bce274 into strapi:master Apr 24, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.12.1 milestone Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language selector not visible
4 participants