RxSO(2) and Sim(2) #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow I recalled this old pull-request which appears to me quite stupid that I mess up the commits. Will purge it and pull-request again with only adding RxSO(2) and Sim(2)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Hauke,
I have successfully merged your current develop branch. Just encountered one issue that the defined tan(*) function in ceres_eigen.hpp won't compile since the Ceres has defined them in jet.h (exactly the same). Is this probably because the Ceres version on my machine is different from yours? But anyway you can make the decision for wether to merge it.
Cheers,
Pinglin