Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments about libblkid versions #1833

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Update comments about libblkid versions #1833

merged 2 commits into from
Feb 21, 2020

Conversation

mulkieran
Copy link
Member

Related: #1656.

@mulkieran mulkieran self-assigned this Feb 20, 2020
@mulkieran mulkieran added this to In progress (long term) in 2020February via automation Feb 20, 2020
@mulkieran mulkieran moved this from In progress (long term) to In progress in 2020February Feb 20, 2020
@mulkieran mulkieran force-pushed the develop-2.0.1-libblkid branch 2 times, most recently from 241a483 to b2561d1 Compare February 20, 2020 20:54
@mulkieran
Remove comment about libblkid version in find_all method
6a96a0b 
Even Fedora 30 now has a version of libblkid that recognizes Stratis
devices.

We can't be certain that we can actually change the behavior, due to the
other reasons given for not finding Stratis devices.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Remove comment about libblkid version in dev_info method
6bf1f99 
Replace this with a new comment which is about the use of libblkid
explicitly rather than via udev to verify that a device is truly
unowned.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran changed the title Remove behavior intended to support lower versions of libblkid Update comments about libblkid versions Feb 20, 2020
@mulkieran mulkieran moved this from In progress to In review in 2020February Feb 20, 2020
@mulkieran
Copy link
Member Author

Failure in stratisd-nonrust looked goofy, so I just restarted.

@mulkieran mulkieran merged commit e2be20a into stratis-storage:develop-2.0.1 Feb 21, 2020
2020February automation moved this from In review to Done Feb 21, 2020
@mulkieran mulkieran deleted the develop-2.0.1-libblkid branch February 21, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

@bgurney-rh bgurney-rh bgurney-rh approved these changes

@drckeefe drckeefe drckeefe approved these changes

@lleshchi lleshchi lleshchi approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
No open projects
2020February
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mulkieran @jbaublitz @bgurney-rh @drckeefe @lleshchi