Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require libblkid 2.32 #1656

Closed
Tracked by #1659
mulkieran opened this issue Oct 10, 2019 · 5 comments
Closed
Tracked by #1659

Require libblkid 2.32 #1656

mulkieran opened this issue Oct 10, 2019 · 5 comments
Assignees
Labels
linked linked to external bug tracker sub-issue issue that has a parent

Comments

@mulkieran
Copy link
Member

This contains the additions which recognize Stratis metadata. If we do this, we can drop the fallback mechanism that exists in the device discovery portion that is intended to cover the situation where libblkid 2.32 is not available.

@mulkieran mulkieran self-assigned this Oct 10, 2019
@mulkieran mulkieran added this to To do in 2019October via automation Oct 10, 2019
@mulkieran mulkieran added the sub-issue issue that has a parent label Oct 15, 2019
@mulkieran mulkieran added this to To do in 2019November via automation Oct 30, 2019
@mulkieran mulkieran removed this from To do in 2019October Oct 30, 2019
@mulkieran
Copy link
Member Author

Removing the sub-issue from the board, just leaving the issue.

@mulkieran mulkieran removed this from To do in 2019November Nov 18, 2019
@mulkieran
Copy link
Member Author

We'll remove anything that exists solely to support lower versions of libblkid, document it in the changelog and elsewhere, and expect downstream to package appropriately.

@mulkieran mulkieran added this to To do in 2020January via automation Dec 20, 2019
@mulkieran mulkieran added promote? promote to external bug tracker linked linked to external bug tracker and removed promote? promote to external bug tracker labels Jan 10, 2020
@mulkieran
Copy link
Member Author

@mulkieran mulkieran added this to To do in 2020February via automation Jan 31, 2020
@mulkieran mulkieran removed this from To do in 2020January Jan 31, 2020
@mulkieran
Copy link
Member Author

Even Fedora 30's default version of libblkid suppports recognizing stratis devices, so we can, at least, drop a bunch of comments.

@mulkieran
Copy link
Member Author

We might as well close this, as any actions remaining in the code base are unrelated to the libblkid version. The bz can persist independently, as it is really now just a downstream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linked linked to external bug tracker sub-issue issue that has a parent
Projects
No open projects
2020February
  
Done
Development

No branches or pull requests

2 participants