Do not dump lots and lots of text on certain failures in tests #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
develop-2.0.1-remove-dump
branch
2 times, most recently
from
2141fae
to
04ffbdf
Compare
|
This is related to #1892, in the sense that I was looking to see if the volume of code that has pylint errors could be reduced. I decided to be more conservative than I had planned, so I haven't reduced the number of pylint errors, just split them across more directories. |
jbaublitz
approved these changes
Mar 27, 2020
lleshchi
approved these changes
Mar 27, 2020
bgurney-rh
approved these changes
Mar 27, 2020
drckeefe
approved these changes
Mar 27, 2020
It is way too much to read through in logs. Move _stratis_id.py and code that only it depends on to the stratisd scripts directory. _stratis_id.py was originally written for two reasons. * It allowed dumping out lots of signature block information if udev tests failed. This was written to attempt to find out the cause of an intermittent failure in the udev tests. But the output is voluminous and turned out not to be very useful as it was found that the cause of the intermittent failures was that occasionally the CreatePool command would fail, because it was called before the loopbacked devices were properly set up, but that the test would ignore that failure and proceed. This problem has been fixed. * The version of libblkid that recognizes Stratis devices was not yet generally available, so the _stratis_id.py script provided a programmatic way to identify Stratis block devices. In most cases, however, blkid is now just as good. The reason to keep the stratis_id.py script around in the scripts directory, is that it provides a structured view of a Stratis signature buffer that it has read. This is not yet provided by other tools, although the plan is to ultimately provide it by means of a Rust program that uses the metadata module which is currently part of stratisd, but which could be exported as a separate crate. In the meantime, it seems reasonable to leave the script where it is accessible to us to possibly be helpful in looking for Stratis metadata on devices. This is not a script that we would choose to release. Add the usual infrastructure for the newly introduced directory, but do not try to improve the script at this time. We can wait until it either gets more use or withers away entirely. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
develop-2.0.1-remove-dump
branch
from
04ffbdf
to
2eca258
Compare
|
rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1656.
Related: #1892