Remove process_unowned_devices #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
changed the title
jbaublitz
approved these changes
Apr 2, 2020
bgurney-rh
approved these changes
Apr 2, 2020
drckeefe
approved these changes
Apr 2, 2020
What functionality can be tested without the use of find_all_block_devices_with_stratis_signatures is already tested, including with encryption, in test_ownership. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Get the data about the block devices to use in testing from the backstore itself. Signed-off-by: mulhern <amulhern@redhat.com>
Remove the method from the identify module. Signed-off-by: mulhern <amulhern@redhat.com>
Now that stratisd reqires libblkid 2.32, and the method is no longer used for test specific purposes, it is no longer needed. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
develop-2.0.1-tests
branch
from
20b6f6e
to
c22c177
Compare
|
rebased. |
lleshchi
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1656
Related: #1782
Also removes find_all_block_devices_with_stratis_signatures, a method used only for testing. In one case, a test was removed. For all other tests, a different mechanism for getting the necessary information was used. find_all_block_devices_with_stratis_signatures depended transitively on process_unowned_devices, and failed to find all devices if the use in identify_block_device was removed. The use in tests was the only reason to retain process_unowned_devices; at this point it can be removed entirely.