Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context manager where possible #2758

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Use context manager where possible #2758

merged 1 commit into from
Aug 27, 2021

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran self-assigned this Aug 23, 2021
@mulkieran
Copy link
Member Author

Where other instances are identified by pylint where we can not use a context manager should clean up file handles better, see characteristic failure when unique_instance test or test_duplicate_pool_name in udev tests fails.

test_duplicate_pool_name (tests.udev.test_udev.UdevTest5) ... ERROR
/usr/lib64/python3.7/subprocess.py:883: ResourceWarning: subprocess 11378 is still running
  ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/lib64/python3.7/unittest/case.py:656: ResourceWarning: unclosed file <_io.TextIOWrapper name=3 encoding='UTF-8'>
  outcome.errors.clear()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/lib64/python3.7/unittest/case.py:656: ResourceWarning: unclosed file <_io.TextIOWrapper name=6 encoding='UTF-8'>
  outcome.errors.clear()
ResourceWarning: Enable tracemalloc to get the object allocation traceback

@mulkieran mulkieran marked this pull request as ready for review August 27, 2021 15:46
@mulkieran
Use context manager where possible
aae29b1 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

rebased.

@mulkieran mulkieran merged commit 0ab8c96 into stratis-storage:develop-2.4.2 Aug 27, 2021
@mulkieran mulkieran deleted the project-issue-342 branch August 27, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mulkieran