Metadata rework #3274
Metadata rework #3274
Conversation
jbaublitz
force-pushed
the
metadata-rework
branch
3 times, most recently
from
2adb0d7
to
ffbb713
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
from
ffbb713
to
f536d25
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
4 times, most recently
from
b1c1859
to
60b55d4
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
from
60b55d4
to
9efd85d
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
3 times, most recently
from
f8f6dbf
to
ab18cbe
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
2 times, most recently
from
71091a0
to
6acfa9f
Compare
jbaublitz
force-pushed
the
metadata-rework
branch
2 times, most recently
from
832136b
to
966514b
Compare
| None | ||
| }; | ||
| log_on_failure!( | ||
| device.activate_handle().activate_by_passphrase( |
There was a problem hiding this comment.
Supposing you get the correct keyslot, but also supply a bad passphrase, the error message is very low-level: Cryptsetup error: IO error occurred: Operation not permitted (os error 1). It might be better to map to something a bit more user-friendly here as well.
There was a problem hiding this comment.
This error is not specific to this PR and existed previously. I am willing to put up another PR that we can merge separately, but I don't think it belongs here.
| } | ||
|
|
||
| Ok(engine.start_pool(id, unlock_method).await?.is_changed()) | ||
| Ok(engine |
There was a problem hiding this comment.
Because of the change here, I think you will also want a change in src/bin/stratis-min/stratis-min.rs specifically around the error message "--prompt and an unlock_method of clevis are mutually exclusive". I think that should no longer be true after this PR, because it is not true on the D-Bus side.
This test code here also illustrates the current behavior: #3635 .
This commit adds the ability to allocate both data and metadata from either the front of the back of the device. This will be necessary for reserving integrity space at the end of the device.
jbaublitz
force-pushed
the
metadata-rework
branch
from
966514b
to
ef5f256
Compare
Related to stratis-storage/project#553