Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check in IdleMemberKicker (#673) #674

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add null check in IdleMemberKicker (#673) #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Stratis.Bitcoin.Features.PoA/Voting/IdleFederationMembersKicker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,19 @@ public void Execute(ChainedHeader consensusTip)
this.SaveMembersByLastActiveTime();

// Check if any fed member was idle for too long. Use the timestamp of the mined block.
foreach (KeyValuePair<PubKey, uint> fedMemberToActiveTime in this.fedPubKeysByLastActiveTime)
foreach (KeyValuePair<PubKey, uint> fedMemberToActiveTime in this.fedPubKeysByLastActiveTime.ToList())
{
if (this.ShouldMemberBeKicked(fedMemberToActiveTime.Key, consensusTip.Header.Time, out uint inactiveForSeconds))
{
IFederationMember memberToKick = this.federationManager.GetFederationMembers().SingleOrDefault(x => x.PubKey == fedMemberToActiveTime.Key);

// If the federation member is not present in the federation, remove it and continue.
if (memberToKick == null)
{
this.fedPubKeysByLastActiveTime.Remove(fedMemberToActiveTime.Key, out _);
continue;
}

byte[] federationMemberBytes = this.consensusFactory.SerializeFederationMember(memberToKick);

bool alreadyKicking = this.votingManager.AlreadyVotingFor(VoteKey.KickFederationMember, federationMemberBytes);
Expand Down