Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JN with JD text and StratumV2 with Stratum v2 #182

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

pavlenex
Copy link
Collaborator

It doesn't do any contextual edits. We'll have to do some work on docs/index.md in general as it doesn't seem accurate in general. @GitGab19 maybe this edits of /docs/index.md is something you'd like to review in the future, but for now this PR specifically addresses #175 text, image replacement will follow in another PR as I edit out the graphics.

closes #175

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for startling-capybara-2231ea ready!

Name Link
🔨 Latest commit 0615bc9
🔍 Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/65200b233ea3aa000775ed33
😎 Deploy Preview https://deploy-preview-182--startling-capybara-2231ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little typos to fix

src/docs/index.md Outdated Show resolved Hide resolved
src/features.md Outdated Show resolved Hide resolved
src/features.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
@GitGab19
Copy link
Collaborator

It doesn't do any contextual edits. We'll have to do some work on docs/index.md in general as it doesn't seem accurate in general. @GitGab19 maybe this edits of /docs/index.md is something you'd like to review in the future, but for now this PR specifically addresses #175 text, image replacement will follow in another PR as I edit out the graphics.

closes #175

Agree with you. There is something to change there.
Next week I think I'll get time to have a general review and propose some changes!

Co-Authored-By: Gabriele Vernetti <62447440+GitGab19@users.noreply.github.com>
@pavlenex
Copy link
Collaborator Author

pavlenex commented Oct 2, 2023

Thanks for a review @GitGab19 Addressed all your suggestions in 82a443a

There are probably a lot of things we'd have to do in GettingStarted.md as it still has a lot of mentions on JN, but let's do that in a separate PR where we will focus on simplifying docs and ensuring it's correct with our latest changes.

@pavlenex
Copy link
Collaborator Author

pavlenex commented Oct 6, 2023

@GitGab19 I've reverted the docs/index.md page since you're working on it in #187 so I think we can merge this one.

@pavlenex pavlenex merged commit e220bfb into stratum-mining:main Oct 6, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace mentions of Job Negotiator with Job Declarator
2 participants