Delete loopback P4 pipeline and Python rules
#872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
commented
Dec 14, 2021
pudelkoM
force-pushed
the
delete-pipelines-loopback
branch
from
b5b071a
to
9522999
Compare
|
After this change, |
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
=======================================
Coverage 78.80% 78.80%
=======================================
Files 336 336
Lines 30128 30128
=======================================
+ Hits 23742 23743 +1
+ Misses 6386 6385 -1
|
pudelkoM
force-pushed
the
delete-pipelines-loopback
branch
from
9522999
to
cfe9818
Compare
pudelkoM
changed the title
stratum/pipelines/loopback P4 pipelineloopback P4 pipeline and Python rules
Yi-Tseng
reviewed
Jan 6, 2022
Comment on lines
-81
to
-86
| if "build_stack_rules_proto" not in native.existing_rules(): | ||
| remote_workspace( | ||
| name = "build_stack_rules_proto", | ||
| remote = "https://github.com/stackb/rules_proto", | ||
| commit = "2f4e4f62a3d7a43654d69533faa0652e1c4f5082", | ||
| ) |
There was a problem hiding this comment.
@pudelkoM I realized that this makes all Jenkins build fail, we need this to build PI related things
pudelkoM
pushed a commit
that referenced
this pull request
Jan 6, 2022
5abeel
pushed a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 9, 2024
This change removes the unused `loopback` P4 pipeline and associated Python code.
5abeel
pushed a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 9, 2024
PR stratum#872 removed a few (seemingly) unneeded dependencies. As CI is not building the `stratum_bf/stratum_bfrt` targets we did not catch the missing dependency for older PI versions, which requires `build_stack_rules_proto`.
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 13, 2024
- Merge upstream PR stratum#872 Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
- Merge upstream PR stratum#872 Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to clean up some leftovers from ye olden times.
That whole
loopbackdirectory:If you are a user of that P4 pipeline or have other concerns, please reply here. Deletion is postponed until Jan 2022.