Re-add build_stack_rules_proto dep
#888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wea re using old version of PI for stratum_bf target which requires build_stack_rules_proto
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 78.80% 78.80%
=======================================
Files 336 336
Lines 30128 30128
=======================================
Hits 23742 23742
Misses 6386 6386 |
pudelkoM
approved these changes
Jan 6, 2022
5abeel
pushed a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 9, 2024
PR stratum#872 removed a few (seemingly) unneeded dependencies. As CI is not building the `stratum_bf/stratum_bfrt` targets we did not catch the missing dependency for older PI versions, which requires `build_stack_rules_proto`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #872 removed a few (seemingly) unneeded dependencies. As CI is not building the
stratum_bf/stratum_bfrttargets we did not catch the missing dependency for older PI versions, which requiresbuild_stack_rules_proto.Note:
Bazel also tries to build PI when building stratum_bfrt target, need to find out the reason.