Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

jsonhttp: config enable CORS #476

Merged
merged 1 commit into from Nov 13, 2018
Merged

jsonhttp: config enable CORS #476

merged 1 commit into from Nov 13, 2018

Conversation

t-bast
Copy link
Contributor

@t-bast t-bast commented Nov 12, 2018

CORS requires options calls to be handled on all routes, so I think that the easiest way is to automatically add an OPTIONS handler on all defined routes when CORS is enabled.


This change is Reviewable

@ghost ghost assigned t-bast Nov 12, 2018
@ghost ghost added the review label Nov 12, 2018
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #476 into master will decrease coverage by 0.19%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #476     +/-   ##
=========================================
- Coverage   70.32%   70.12%   -0.2%     
=========================================
  Files          90       90             
  Lines        5327     5346     +19     
=========================================
+ Hits         3746     3749      +3     
- Misses       1208     1219     +11     
- Partials      373      378      +5
Impacted Files Coverage Δ
fossilizer/fossilizerhttp/cmd.go 0% <0%> (ø) ⬆️
store/storehttp/cmd.go 0% <0%> (ø) ⬆️
jsonhttp/jsonhttp.go 70.32% <33.33%> (-9.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62792d8...582eddb. Read the comment docs.

Copy link
Contributor

@alexppxela alexppxela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bejito and @stephan83)

@t-bast t-bast merged commit d9aadc8 into master Nov 13, 2018
@t-bast t-bast deleted the bt/cors/options branch November 13, 2018 09:01
@ghost ghost removed the review label Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants