store: create links batch #516
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 71.44% 71.58% +0.14%
==========================================
Files 100 100
Lines 5564 5617 +53
==========================================
+ Hits 3975 4021 +46
- Misses 1223 1228 +5
- Partials 366 368 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, 2 unresolved discussions (waiting on @alexppxela, @golangcibot, and @jeremie-stratumn)
postgresstore/benchmark_test.go, line 37 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
createStoreBis unused (fromdeadcode)
Done.
postgresstore/benchmark_test.go, line 58 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
freeStoreBis unused (fromdeadcode)
Done.
There was a problem hiding this comment.
Reviewed 11 of 12 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alexppxela, @golangcibot, and @jeremie-stratumn)
There was a problem hiding this comment.
clean!
Reviewed 11 of 12 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alexppxela and @golangcibot)
There was a problem hiding this comment.
as usual!
Reviewed 11 of 12 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @golangcibot)
store/storetestcases/batch.go, line 91 at r2 (raw file):
}) t.Run("CreateLink should rejects links after failure", func(t *testing.T) {
typo: rejects
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @golangcibot)
store/storetestcases/batch.go, line 91 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
typo: rejects
Good catch! I'll fix that
Add the option to create multiple links in an atomic batch.
I chose to make it explicit that it's a batch by using a new route (it makes it easier for backwards-compatibility too). It's not unrealistic at some point to use the
/linksroute and make it accept a more complex payload (collection of links + a boolean to choose what to do in case of error: atomic or not).Fixes #515
This change is