Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test optimizer with polymorphic relay node #570

Conversation

stygmate
Copy link
Contributor

Add node polymorphism tests and related schema
Update asserts in optimizer.py -> To be double checked before merge

@stygmate
Copy link
Contributor Author

@bellini666 here it is :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (7b8a6a2) to head (fb40e9f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   88.81%   88.94%   +0.13%     
==========================================
  Files          41       41              
  Lines        3531     3547      +16     
==========================================
+ Hits         3136     3155      +19     
+ Misses        395      392       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stygmate :)

I had to do a small modification from isinstance(foo, A | B) to isinstance(foo, (A, B)) as the new syntax is only compatible with python 3.10+, and we are still supporting 3.8/3.9

@bellini666 bellini666 merged commit 87c8f4f into strawberry-graphql:main Jun 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants