Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test optimizer with polymorphic relay node #570

Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions strawberry_django/optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ def _get_model_hints_from_connection(
schema,
get_object_definition(e_type, strict=True),
)
assert isinstance(e_gql_definition, GraphQLObjectType)
assert isinstance(e_gql_definition, (GraphQLObjectType, GraphQLInterfaceType))
e_info = _generate_selection_resolve_info(
info,
edges,
Expand All @@ -856,7 +856,10 @@ def _get_model_hints_from_connection(
continue

n_gql_definition = _get_gql_definition(schema, n_definition)
assert isinstance(n_gql_definition, GraphQLObjectType)
assert isinstance(
n_gql_definition,
(GraphQLObjectType, GraphQLInterfaceType),
)
n_info = _generate_selection_resolve_info(
info,
nodes,
Expand Down
Empty file.
14 changes: 14 additions & 0 deletions tests/node_polymorphism/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from django.db import models
from polymorphic.models import PolymorphicModel


class Project(PolymorphicModel):
topic = models.CharField(max_length=30)


class ArtProject(Project):
artist = models.CharField(max_length=30)


class ResearchProject(Project):
supervisor = models.CharField(max_length=30)
35 changes: 35 additions & 0 deletions tests/node_polymorphism/schema.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@

import strawberry
from strawberry.relay import ListConnection

import strawberry_django
from strawberry_django.optimizer import DjangoOptimizerExtension

from .models import ArtProject, Project, ResearchProject


@strawberry_django.interface(Project)
class ProjectType(strawberry.relay.Node):
topic: strawberry.auto


@strawberry_django.type(ArtProject)
class ArtProjectType(ProjectType):
artist: strawberry.auto


@strawberry_django.type(ResearchProject)
class ResearchProjectType(ProjectType):
supervisor: strawberry.auto


@strawberry.type
class Query:
projects: ListConnection[ProjectType] = strawberry_django.connection()


schema = strawberry.Schema(
query=Query,
types=[ArtProjectType, ResearchProjectType],
extensions=[DjangoOptimizerExtension],
)
52 changes: 52 additions & 0 deletions tests/node_polymorphism/test_optimizer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import pytest

from .models import ArtProject, ResearchProject
from .schema import schema


@pytest.mark.django_db(transaction=True)
def test_polymorphic_interface_query():
ap = ArtProject.objects.create(topic="Art", artist="Artist")
rp = ResearchProject.objects.create(topic="Research", supervisor="Supervisor")

query = """\
query {
projects {
edges {
node {
__typename
topic
... on ArtProjectType {
artist
}
... on ResearchProjectType {
supervisor
}
}
}
}
}
"""

result = schema.execute_sync(query)
assert not result.errors
assert result.data == {
"projects": {
"edges": [
{
"node": {
"__typename": "ArtProjectType",
"topic": ap.topic,
"artist": ap.artist,
}
},
{
"node": {
"__typename": "ResearchProjectType",
"topic": rp.topic,
"supervisor": rp.supervisor,
}
},
]
}
}
Loading