fix: list connection optimization (#3487)

RELEASE.md

@@ -0,0 +1,4 @@
+Release type: patch
+
+This release fixes a bug in release 0.227.3 where FragmentSpread nodes
+were not resolving edges.

strawberry/relay/utils.py

@@ -3,7 +3,7 @@
 from typing_extensions import assert_never
 
 from strawberry.types.info import Info
-from strawberry.types.nodes import InlineFragment
+from strawberry.types.nodes import InlineFragment, Selection
 from strawberry.types.types import StrawberryObjectDefinition
 
 
@@ -77,11 +77,28 @@ def should_resolve_list_connection_edges(info: Info) -> bool:
 
     """
     resolve_for_field_names = {"edges", "pageInfo"}
+
+    def _check_selection(selection: Selection) -> bool:
+        """Recursively inspect the selection to check if the user requested to resolve the `edges` field.
+        Args:
+            selection (Selection): The selection to check.
+
+        Returns:
+            bool: True if the user requested to resolve the `edges` field of a connection, False otherwise.
+        """
+        if (
+            not isinstance(selection, InlineFragment)
+            and selection.name in resolve_for_field_names
+        ):
+            return True
+        if selection.selections:
+            return any(
+                _check_selection(selection) for selection in selection.selections
+            )
+        return False
+
     for selection_field in info.selected_fields:
         for selection in selection_field.selections:
-            if (
-                not isinstance(selection, InlineFragment)
-                and selection.name in resolve_for_field_names
-            ):
+            if _check_selection(selection):
                 return True
     return False

tests/relay/test_types.py

@@ -289,3 +289,35 @@ class Query:
             "totalCount": -1,
         }
     }
+
+
+def test_list_connection_with_nested_fragments():
+    ret = schema.execute_sync(
+        """
+    query {
+      fruits {
+        ...FruitFragment
+      }
+    }
+
+    fragment FruitFragment on FruitConnection {
+        edges {
+            node {
+                id
+            }
+        }
+    }
+    """
+    )
+    assert ret.errors is None
+    assert ret.data == {
+        "fruits": {
+            "edges": [
+                {"node": {"id": "RnJ1aXQ6MQ=="}},
+                {"node": {"id": "RnJ1aXQ6Mg=="}},
+                {"node": {"id": "RnJ1aXQ6Mw=="}},
+                {"node": {"id": "RnJ1aXQ6NA=="}},
+                {"node": {"id": "RnJ1aXQ6NQ=="}},
+            ]
+        }
+    }