Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate starlite #3359

Closed
3 tasks
patrick91 opened this issue Jan 24, 2024 · 2 comments 路 Fixed by #3492
Closed
3 tasks

Deprecate starlite #3359

patrick91 opened this issue Jan 24, 2024 · 2 comments 路 Fixed by #3492
Labels
good first issue Good for newcomers

Comments

@patrick91
Copy link
Member

patrick91 commented Jan 24, 2024 •
edited by polar-sh bot
Loading

Now that we Litestar support I think we can deprecate Starlite 馃槉

Tasks
Beta Give feedback

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@patrick91 patrick91 added the good first issue Good for newcomers label Jan 24, 2024
@Birdi7
Copy link
Contributor

Birdi7 commented May 1, 2024

Hello! Do you mind if I take this issue? Is it still up-to-date and should be done?

@erikwrede
Copy link
Member

@Birdi7 Please feel free to go ahead with this 馃槉 If you need assistance or a review, feel free to ping me

Birdi7 added a commit to Birdi7/strawberry that referenced this issue May 8, 2024
@Birdi7
fix: deprecate starlite integration. closes strawberry-graphql#3359
04985ca
@Birdi7 Birdi7 mentioned this issue May 8, 2024
Merged
11 tasks
Birdi7 added a commit to Birdi7/strawberry that referenced this issue May 8, 2024
@Birdi7
fix: deprecate starlite integration. closes strawberry-graphql#3359
82dd811 
test + deprecate class
Birdi7 added a commit to Birdi7/strawberry that referenced this issue May 8, 2024
@Birdi7
fix: deprecate starlite integration. closes strawberry-graphql#3359
fcd8b53 
test + deprecate class
patrick91 added a commit that referenced this issue May 11, 2024
@Birdi7 @patrick91
fix: deprecate starlite integration. closes #3359 (#3492)
1ad5fb6 
* fix: deprecate starlite integration. closes #3359

test + deprecate class

* wip

* wip

* wip

* Fix test

---------

Co-authored-by: Patrick Arminio <patrick.arminio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deprecate starlite integration. closes #3359 Birdi7/strawberry
3 participants
@patrick91 @erikwrede @Birdi7