Move where we create the resolvers for our fields #1044
Conversation
|
Thanks for adding the Here's a preview of the changelog: This release only changes some internal code to make future improvements |
Codecov Report
@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 78 78
Lines 2813 2811 -2
Branches 382 383 +1
==========================================
- Hits 2750 2748 -2
Misses 41 41
Partials 22 22 |
| def _get_arguments( | ||
| self, | ||
| field: StrawberryField, | ||
| source: Any, | ||
| info: Any, | ||
| kwargs: Dict[str, Any], | ||
| ) -> Tuple[List[Any], Dict[str, Any]]: | ||
| if field.base_resolver is None: | ||
| return [], {} | ||
|
|
||
| kwargs = convert_arguments(kwargs, field.arguments) | ||
|
|
||
| # the following code allows to omit info and root arguments | ||
| # by inspecting the original resolver arguments, | ||
| # if it asks for self, the source will be passed as first argument | ||
| # if it asks for root, the source it will be passed as kwarg | ||
| # if it asks for info, the info will be passed as kwarg | ||
|
|
||
| args = [] | ||
|
|
||
| if field.base_resolver.has_self_arg: | ||
| args.append(source) | ||
|
|
||
| if field.base_resolver.has_root_arg: | ||
| kwargs["root"] = source | ||
|
|
||
| if field.base_resolver.has_info_arg: | ||
| kwargs["info"] = info | ||
|
|
||
| return args, kwargs |
There was a problem hiding this comment.
Can this method be embedded in from_resolver with the other functions? It doesn't need any state on the class and is only consumed by that one method.
There was a problem hiding this comment.
I know that from_resolver is getting quite long, but I still think that would be cleaner
| source: Any, | ||
| info: Any, |
There was a problem hiding this comment.
Do source and info have known types now?
There was a problem hiding this comment.
info yes, source depends on the resolver, so I think any is good :)
Description
This PR moves where we create our custom resolver for fields. Our custom logic resolver
is pretty much tied to GraphQL core and the schema. So it makes sense to move it there,
it will also help with the auto_camel_case changes, as we need to know if we have auto
camel casing on when fetching the arguments.
Types of Changes