Update await_maybe #1505
Merged
Update await_maybe #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Thanks for adding the Here's a preview of the changelog: This release modifies the internal utility function Here's the preview release card for twitter: Here's the tweet text: |
patrick91
reviewed
Dec 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #1505 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 128 128
Lines 4396 4396
Branches 746 746
=======================================
Hits 4313 4313
Misses 43 43
Partials 40 40 |
patrick91
approved these changes
Dec 20, 2021
| @@ -8,7 +8,7 @@ | |||
|
|
|||
|
|
|||
| async def await_maybe(value: AwaitableOrValue): | |||
| if inspect.iscoroutine(value): | |||
| if inspect.isawaitable(value): | |||
There was a problem hiding this comment.
https://github.com/python/cpython/blob/main/Lib/inspect.py#L446-L451 all good I'd say :)
|
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
iscoroutinewithisawaitableinawait_maybetowards the update to mypy 0.920.Details
We are currently on version 0.910 of mypy, and are working towards updating to 0.920 in #1503.
In the new mypy version we get the following error in
await_maybe:This PR modifies the function to use
isawaitableinstead ofiscorotuine, which fixes the error.Types of Changes
Checklist