Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitHub worflow for tests #1913

Merged
merged 13 commits into from
May 19, 2022

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented May 17, 2022

This PR:

  • Removes our custom cache implementation in favour of setup-python's one (less code for us)
  • moves the windows test to only one version of python (to make tests faster and simplify the setup)
  • adds a new matrix for starlette
  • moves pyright and mypy tests on a different job

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1913 (a6092b4) into main (1b85e0c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         143      143           
  Lines        5562     5562           
  Branches     1023     1023           
=======================================
  Hits         5453     5453           
  Misses         56       56           
  Partials       53       53           

@patrick91 patrick91 force-pushed the test-matrix-starlette branch 16 times, most recently from 8225b3d to c11572b Compare May 19, 2022 02:46
@patrick91 patrick91 marked this pull request as ready for review May 19, 2022 02:50
@botberry
Copy link
Member

botberry commented May 19, 2022

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@patrick91 patrick91 merged commit 35a627d into strawberry-graphql:main May 19, 2022
@patrick91 patrick91 deleted the test-matrix-starlette branch May 19, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants